Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forbid breaking the system [Focal] #2

Merged
merged 2 commits into from Oct 28, 2021
Merged

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Oct 27, 2021

Same as #1

@mmstick mmstick requested review from a team October 27, 2021 14:04
@jacobgkau
Copy link
Member

This doesn't seem to be in staging for Focal at all, even though only the i386 build failed. (It looks like i386 builds were working on the Hirsute/Impish branch.)

@jackpot51
Copy link
Member

It will need to succeed on all arch builds to publish on staging

@mmstick
Copy link
Member Author

mmstick commented Oct 27, 2021

Will fix once I get power back.

@mmstick mmstick force-pushed the break_focal branch 2 times, most recently from 267896b to 7727a29 Compare October 27, 2021 20:36
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

97e06ab still shows as not built for binary-i386, but it is in the staging repo now. master_focal also shows not built for binary-i386, and this branch is working the same as #1, so I'm approving.

@mmstick
Copy link
Member Author

mmstick commented Oct 28, 2021

Yeah I'm confused on what's wrong with the i386 builds. CMake is having a configuration error where it simultaneously claims that it has found dependencies whilst also claiming it cannot find them. Seems to be a general issue with Cmake on Focal with i386 from what I've found.

@mmstick mmstick merged commit e6bd69a into master_focal Oct 28, 2021
@mmstick mmstick deleted the break_focal branch October 28, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants